Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor update workflow signature #9688

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Refactor update workflow signature #9688

merged 1 commit into from
Jan 13, 2025

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #9607

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 9, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 9, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9688 will not alter performance

Comparing frode-aarstad:refactor-update-workflow-sig (b087917) with main (5a0ff5f)

Summary

✅ 24 untouched benchmarks

@frode-aarstad frode-aarstad force-pushed the refactor-update-workflow-sig branch 2 times, most recently from 982ca1b to a15a674 Compare January 9, 2025 09:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (5a0ff5f) to head (b087917).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9688      +/-   ##
==========================================
+ Coverage   91.72%   91.73%   +0.01%     
==========================================
  Files         426      426              
  Lines       26550    26550              
==========================================
+ Hits        24352    24356       +4     
+ Misses       2198     2194       -4
Flag Coverage Δ
cli-tests 39.77% <100.00%> (ø)
everest-models-test 34.15% <50.00%> (+<0.01%) ⬆️
gui-tests 74.33% <100.00%> (ø)
integration-test 37.96% <50.00%> (ø)
performance-tests 51.57% <100.00%> (ø)
test 39.49% <50.00%> (ø)
unit-tests 74.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk
Copy link
Contributor

Looks like a good change, I think there should be one more commit propagating this change into es_update.py also, renaming analysis_config to update_settings in _es_update.py added to this PR, starting here:

        try:
            smoother_update(
                prior,
                posterior,
                analysis_config=self._update_settings, #  <----

oyvindeide
oyvindeide previously approved these changes Jan 13, 2025
View reviewed changes
@oyvindeide oyvindeide dismissed their stale review January 13, 2025 07:31

Came another review at the same time requesting changes

@frode-aarstad frode-aarstad force-pushed the refactor-update-workflow-sig branch from a15a674 to b087917 Compare January 13, 2025 09:41
yngve-sk
yngve-sk approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@frode-aarstad frode-aarstad merged commit 051fa31 into equinor:main Jan 13, 2025
42 checks passed
@frode-aarstad frode-aarstad deleted the refactor-update-workflow-sig branch January 13, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngve-sk yngve-sk yngve-sk approved these changes

@oyvindeide oyvindeide oyvindeide left review comments

Assignees

@frode-aarstad frode-aarstad

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor update workflow signature
4 participants
@frode-aarstad @codecov-commenter @yngve-sk @oyvindeide